|Anonymous | Login | Signup for a new account||2013-12-08 22:51 PST|
|Main | My View | View Issues | Change Log | Repositories|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000449||Friendica||plugins||public||2012-06-12 09:51||2012-07-26 00:52|
|Fixed in Version|
|Summary||0000449: showmore and nsfw interfere with each other|
|Description||If a post triggers the nsfw plugin as well as the showmore plugin, it's not possible anymore to view the complete post.|
If I click the nsfw open link first, the post is shown truncated by showmore. If I then click the show more link, it is collapsed again and can't be opened anymore afterwards.
If I click the show more link first, it vanishes, but the post can't be uncollapsed with the nsfw link anymore.
I'm pretty sure that this worked until recently.
|Tags||No tags attached.|
|Was this fixed? I just tried to reproduce the issue, but it seems to be working as I would expect.|
|I hadn't done anything to fix it - but Michael Vogel may have. It's remotely possible that this may be affected by the order in which the plugins are called - though we don't have any easy to change the ordering to test this hypothesis.|
|I can still reproduce the issue (current git).|
showmore was counting what is hidden by nsfw, so it would act anyway.
This commit avoids that: https://github.com/CyberDomovoy/friendica-addons/commit/7b786e02149ba01550a4028bcf0e11b8f575d3ec [^]
We may also need to prioritize the order in which the hooks are run, so that nsfw acts before showmore.
This commit permits that: https://github.com/CyberDomovoy/friendica/commit/d6c600ce112d29cc05dc241246c5124c9447f321 [^]
|Works perfectly, thanks.|
|2012-06-12 09:51||zottel||New Issue|
|2012-07-17 15:09||unary||Note Added: 0000711|
|2012-07-17 15:34||macgirvin||Note Added: 0000712|
|2012-07-18 00:43||zottel||Note Added: 0000713|
|2012-07-23 11:18||Domovoy||Note Added: 0000720|
|2012-07-26 00:52||zottel||Note Added: 0000723|
|2012-07-26 00:52||zottel||Status||new => closed|
|2012-07-26 00:52||zottel||Assigned To||=> zottel|
|2012-07-26 00:52||zottel||Resolution||open => fixed|
|Copyright © 2000 - 2010 MantisBT Group|