0000449: showmore and nsfw interfere with each other

(0000711)
unary (developer)
2012-07-17 15:09

Was this fixed? I just tried to reproduce the issue, but it seems to be working as I would expect.

(0000712)
macgirvin (administrator)
2012-07-17 15:34

I hadn't done anything to fix it - but Michael Vogel may have. It's remotely possible that this may be affected by the order in which the plugins are called - though we don't have any easy to change the ordering to test this hypothesis.

(0000713)
zottel (developer)
2012-07-18 00:43

I can still reproduce the issue (current git).

(0000720)
Domovoy (reporter)
2012-07-23 11:18

showmore was counting what is hidden by nsfw, so it would act anyway.
This commit avoids that: https://github.com/CyberDomovoy/friendica-addons/commit/7b786e02149ba01550a4028bcf0e11b8f575d3ec [^]

We may also need to prioritize the order in which the hooks are run, so that nsfw acts before showmore.
This commit permits that: https://github.com/CyberDomovoy/friendica/commit/d6c600ce112d29cc05dc241246c5124c9447f321 [^]

(0000723)
zottel (developer)
2012-07-26 00:52

Works perfectly, thanks.

Issue History
Date Modified	Username	Field	Change
2012-06-12 09:51	zottel	New Issue
2012-07-17 15:09	unary	Note Added: 0000711
2012-07-17 15:34	macgirvin	Note Added: 0000712
2012-07-18 00:43	zottel	Note Added: 0000713
2012-07-23 11:18	Domovoy	Note Added: 0000720
2012-07-26 00:52	zottel	Note Added: 0000723
2012-07-26 00:52	zottel	Status	new => closed
2012-07-26 00:52	zottel	Assigned To	=> zottel
2012-07-26 00:52	zottel	Resolution	open => fixed

Notes
(0000711) unary (developer) 2012-07-17 15:09	Was this fixed? I just tried to reproduce the issue, but it seems to be working as I would expect.

(0000712) macgirvin (administrator) 2012-07-17 15:34	I hadn't done anything to fix it - but Michael Vogel may have. It's remotely possible that this may be affected by the order in which the plugins are called - though we don't have any easy to change the ordering to test this hypothesis.

(0000713) zottel (developer) 2012-07-18 00:43	I can still reproduce the issue (current git).

(0000720) Domovoy (reporter) 2012-07-23 11:18	showmore was counting what is hidden by nsfw, so it would act anyway. This commit avoids that: https://github.com/CyberDomovoy/friendica-addons/commit/7b786e02149ba01550a4028bcf0e11b8f575d3ec [^] We may also need to prioritize the order in which the hooks are run, so that nsfw acts before showmore. This commit permits that: https://github.com/CyberDomovoy/friendica/commit/d6c600ce112d29cc05dc241246c5124c9447f321 [^]

(0000723) zottel (developer) 2012-07-26 00:52	Works perfectly, thanks.

Relationships