0000431: img tag does not work with https url

(0000644)
macgirvin (administrator)
2012-05-22 16:20

Both work for me in a test post - locally and across sites.

(0000645)
Domovoy (reporter)
2012-05-22 21:54

Hmmm, so what's happening to me?

(0000646)
Domovoy (reporter)
2012-05-22 22:15

If i disable the privacy image cache extensions, everything works fine

(0000647)
macgirvin (administrator)
2012-05-22 22:36

I just patched privacy_image_cache "local detection" so as not to be sensitive to http vs https

(0000648)
Domovoy (reporter)
2012-05-23 09:16

Hmmm, i just updated from git, didn't change anything.

(0000649)
Domovoy (reporter)
2012-05-23 09:17

Actually, something changed, it doesn't work for http either now :)
In bot case i just get the url displayed as text.

(0000650)
Domovoy (reporter)
2012-05-23 09:43

I think the problem is on line 75 of privacy_image_cache.php

It returns the image url there, but if it is not a local image, it returns an <img> tag.

The line should be:
if (privacy_image_cache_is_local_image($matches[2])) return $matches[1] . $matches[2] . $matches[3];

(0000651)
macgirvin (administrator)
2012-05-23 15:45

That looks correct to me also. Changed as requested.

(0000652)
Domovoy (reporter)
2012-05-23 21:55

Everything is good now. Thanks.

You can close this issue

(0000665)
jcsesecuneta (developer)
2012-05-27 18:39

3.0.1355
- Privacy image cache bugs fixed - local images over https now work properly.
https://kakste.com/display/bouldrake/576322 [^]

Notes
(0000644) macgirvin (administrator) 2012-05-22 16:20	Both work for me in a test post - locally and across sites.

(0000645) Domovoy (reporter) 2012-05-22 21:54	Hmmm, so what's happening to me?

(0000646) Domovoy (reporter) 2012-05-22 22:15	If i disable the privacy image cache extensions, everything works fine

(0000647) macgirvin (administrator) 2012-05-22 22:36	I just patched privacy_image_cache "local detection" so as not to be sensitive to http vs https

(0000648) Domovoy (reporter) 2012-05-23 09:16	Hmmm, i just updated from git, didn't change anything.

(0000649) Domovoy (reporter) 2012-05-23 09:17	Actually, something changed, it doesn't work for http either now :) In bot case i just get the url displayed as text.

(0000650) Domovoy (reporter) 2012-05-23 09:43	I think the problem is on line 75 of privacy_image_cache.php It returns the image url there, but if it is not a local image, it returns an <img> tag. The line should be: if (privacy_image_cache_is_local_image($matches[2])) return $matches[1] . $matches[2] . $matches[3];

(0000651) macgirvin (administrator) 2012-05-23 15:45	That looks correct to me also. Changed as requested.

(0000652) Domovoy (reporter) 2012-05-23 21:55	Everything is good now. Thanks. You can close this issue

(0000665) jcsesecuneta (developer) 2012-05-27 18:39	3.0.1355 - Privacy image cache bugs fixed - local images over https now work properly. https://kakste.com/display/bouldrake/576322 [^]

Issue History
Date Modified	Username	Field	Change
2012-05-22 16:03	Domovoy	New Issue
2012-05-22 16:20	macgirvin	Note Added: 0000644
2012-05-22 21:54	Domovoy	Note Added: 0000645
2012-05-22 22:15	Domovoy	Note Added: 0000646
2012-05-22 22:36	macgirvin	Note Added: 0000647
2012-05-23 09:16	Domovoy	Note Added: 0000648
2012-05-23 09:17	Domovoy	Note Added: 0000649
2012-05-23 09:43	Domovoy	Note Added: 0000650
2012-05-23 15:45	macgirvin	Note Added: 0000651
2012-05-23 21:55	Domovoy	Note Added: 0000652
2012-05-27 18:39	jcsesecuneta	Note Added: 0000665
2012-05-27 18:39	jcsesecuneta	Relationship added	duplicate of 0000398
2012-05-27 18:39	jcsesecuneta	Status	new => resolved
2012-05-27 18:39	jcsesecuneta	Resolution	open => fixed
2012-05-27 18:39	jcsesecuneta	Assigned To	=> jcsesecuneta
2012-12-21 14:32	macgirvin	Status	resolved => closed